Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded dependencies; AbstractPlotting -> Makie #21

Merged
merged 10 commits into from
Nov 8, 2024

Conversation

jagot
Copy link
Contributor

@jagot jagot commented Apr 27, 2024

  • Bumped compat bounds
  • Transitioned from AbstractPlotting (deprecated) to Makie; to avoid
    forcing the rather large dependency on users, the Makie plotting
    recipes are in a package extension.
  • Dropped Julia < 1.9, since that is when package extensions were introduced
  • Test plotting recipes on CI (just that they do not crash, no actual
    tests of the output)
  • Bumped version 0.2.1 -> 0.2.2, but maybe we want to go to 0.3.0?

I did not make the plot recipes interactive (as discussed
here),
but if it is interesting, that could be done in a later PR.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.69%. Comparing base (dc5979b) to head (4405394).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #21       +/-   ##
===========================================
+ Coverage   65.06%   95.69%   +30.63%     
===========================================
  Files           1        2        +1     
  Lines          83       93       +10     
===========================================
+ Hits           54       89       +35     
+ Misses         29        4       -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlfivefifty dlfivefifty merged commit 68d9571 into JuliaHolomorphic:master Nov 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants